[tda] Critical Experiences - switch to 24 hour cycle #668
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #668 +/- ##
=======================================
Coverage 34.13% 34.13%
=======================================
Files 37 37
Lines 920 920
Branches 111 111
=======================================
Hits 314 314
Misses 589 589
Partials 17 17
|
There was a problem hiding this comment.
Curious on why the change to // rather than %
Wouldn't this make the probabilities that come up look less random?
| Hour | now.hour // 4 | now.hour % 4 | Same? |
|---|---|---|---|
| 0 | 0 | 0 | Yes |
| 1 | 0 | 1 | No |
| 2 | 0 | 2 | No |
| 3 | 0 | 3 | No |
| 4 | 1 | 0 | No |
| 5 | 1 | 1 | No |
| 6 | 1 | 2 | No |
| 7 | 1 | 3 | No |
| 8 | 2 | 0 | No |
| 9 | 2 | 1 | No |
| 10 | 2 | 2 | No |
| 11 | 2 | 3 | No |
| 12 | 3 | 0 | No |
| 13 | 3 | 1 | No |
| 14 | 3 | 2 | No |
| 15 | 3 | 3 | No |
| 16 | 4 | 0 | No |
| 17 | 4 | 1 | No |
| 18 | 4 | 2 | No |
| 19 | 4 | 3 | No |
| 20 | 5 | 0 | No |
| 21 | 5 | 1 | No |
| 22 | 5 | 2 | No |
| 23 | 5 | 3 | No |
Though % 4 will not come up to 5 by nature. It would be more cyclical though, right?
|
hey @gid-sentry Before After that way we'd just have more datapoints => less noise, spikes etc.
there are no probabilities now or after the change, entirely deterministic |
This should make graphs a little smoother
If this is not enough we can switch to 6-day cycle (or 14/30-day to match what SE will often have as time interval during demos)
Eventually we want this to be on a 6 week cycle to match releases (can now be overlayed in dashboards)